public/soundy-bits
1
0
Fork 0
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity Actions

feat(headless): vendor libopus (pure Rust, no system dep) #12

Closed
psk wants to merge 0 commits from chore/vendor-libopus into master
pull from: chore/vendor-libopus
merge into: public:master
Conversation 1 Commits - Files changed - +39 -100
psk commented 2026-06-28 12:12:42 +00:00
Owner
Copy link

Vendors libopus so the headless render needs no system libopus — addresses the dislike of low-level external deps.

  • Swaps audiopus (→ audiopus_sys → system libopus, needed libopus-dev) for the opus fork's unsafe-libopus backend (libopus transpiled to Rust by c2rust). Pure Rust — no C compiler/cmake/autotools, no libopus-dev.
  • opus.rs rewired to the opus crate API (3 lines). EncodeError is Box<dyn Error>, so no error-plumbing change.
  • Docs flipped to "vendored, self-contained"; TODO.md drops the shipped "Headless in releases" plan.

Verified: clippy 0 warnings · 95 tests green · ldd/readelf confirm no direct libopus (audiopus gone from the lockfile) · render smoke test → valid MP4 (ffprobe: codec=opus, 2ch). The only remaining libopus.so is transitive via libpulse (loopback), unchanged.

Vendors libopus so the headless render needs **no system libopus** — addresses the dislike of low-level external deps. - Swaps `audiopus` (→ `audiopus_sys` → system libopus, needed `libopus-dev`) for the [`opus`](https://github.com/DCNick3/opus-rs) fork's **`unsafe-libopus`** backend (libopus transpiled to Rust by c2rust). Pure Rust — no C compiler/cmake/autotools, no `libopus-dev`. - `opus.rs` rewired to the `opus` crate API (3 lines). `EncodeError` is `Box<dyn Error>`, so no error-plumbing change. - Docs flipped to "vendored, self-contained"; TODO.md drops the shipped "Headless in releases" plan. **Verified:** clippy 0 warnings · 95 tests green · `ldd`/`readelf` confirm no direct `libopus` (audiopus gone from the lockfile) · render smoke test → valid MP4 (`ffprobe`: `codec=opus`, 2ch). The only remaining `libopus.so` is transitive via `libpulse` (loopback), unchanged.
feat(headless): vendor libopus as pure Rust (drop the system libopus dep)
All checks were successful
ci / build-and-test (pull_request) Successful in 8m29s
Details
8c4556d473
 
Replace audiopus (-> audiopus_sys -> system libopus; needed libopus-dev to
build and libopus.so at runtime) with the opus-rs fork's unsafe-libopus
backend — libopus transpiled to Rust by c2rust. The Opus encoder now
compiles into the binary: no libopus-dev, no system libopus, no
autotools/cmake.

- Cargo.toml: audiopus "0.2" -> opus (DCNick3/opus-rs, unsafe-libopus-backend).
- opus.rs: audiopus API -> opus crate (u32 sample rate, mut encoder).
- audiopus/audiopus_sys gone from the lockfile; the binary no longer
  directly links libopus (only transitively via libpulse for loopback).
- Docs: CLAUDE.md/README flip "needs libopus-dev" -> vendored; TODO.md drops
  the now-shipped "Headless in releases" packaging plan.

Verified: clippy clean, 95 tests pass, ldd/readelf show no direct libopus,
and a render smoke test yields a valid MP4 (ffprobe: codec=opus, 2ch).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
psk closed this pull request 2026-06-28 12:26:41 +00:00
psk commented 2026-06-28 12:27:05 +00:00
Author
Owner
Copy link

Closing — opened in error (auto-opened without being asked). The chore/vendor-libopus branch stays; work continues on it.

Closing — opened in error (auto-opened without being asked). The chore/vendor-libopus branch stays; work continues on it.
All checks were successful
ci / build-and-test (pull_request) Successful in 8m29s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
public/soundy-bits!12
No description provided.