ci: set git identity in its own step so tag-once can create the annotated tag #19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/release-pr-tag-identity"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Fix the one bug in the new
release-pr.yml: the tag-once step (git tag -a, annotated) needs a committer identity, but the identity was set inside the engine step on only the "open a Release PR" path. The no-op path (the Release-PR merge push,next == current) exits before it — so when the v0.3.2 Release PR merged, tag-once failed (empty ident name, exit 128) and the tag was never pushed.Move the identity to a dedicated step right after checkout, so it's present on every path for both the release-pr commit and the tag-once tag.
Status of v0.3.2
The engine worked — it auto-opened the v0.3.2 Release PR (#18) correctly. Only tag-once failed. v0.3.2 was tagged manually via local tooling to unblock the release, so
release.ymlis publishing it now. This PR makes the automatic tag-on-merge work for every future release with zero manual steps.Safe to merge
Committed as
ci:→cliff.tomlskips it, so merging opens no new Release PR, and tag-once no-ops (v0.3.2 already tagged). Clean.7598977848db830b1d45